Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recognition of Scientific Linux #48

Merged
merged 1 commit into from
Nov 14, 2014
Merged

Added recognition of Scientific Linux #48

merged 1 commit into from
Nov 14, 2014

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Nov 13, 2014

I'll confess I didn't see where 'on oel' was comming from, but this should at least get SL support started.

@ekohl
Copy link
Member

ekohl commented Nov 13, 2014

oel is just an example of something in the RedHat osfamily, but the actual value of $::operatingsystem here doesn't really matter. This is also just compile time checks and no actual OS installations begin tested. That means I consider this mostly cosmetic. However, I do think SL is more likely to be used some I'd be fine with this.

@stbenjam
Copy link
Member

Hi @jcpunk, thanks for the PR. I don't understand the goal of it though - this is our (admittedly limited) test suite for the puppet module.

Any non-Fedora, non-RedHat value is valid for the spec, be it SL, or OEL. We're not expressing support or any kind of preference here.

@jcpunk
Copy link
Contributor Author

jcpunk commented Nov 14, 2014

For the most part, I ran into http://projects.theforeman.org/issues/7882 and said, "I should look for anything else that snuck through on HEAD".

Since the OEL stanza was duplicated, I figured swapping it over to say SL was an easy way of trying to make sure the installer was ready for anything.

@stbenjam
Copy link
Member

@jcpunk Ah I see, thanks - I didn't realize the OEL spec was duplicated. I've also got no problem with this then, thanks!

Regarding 7882, that is fixed in our git repositories and should go out with the next release - you can try on the nightlies today, or try the patch over at #41.

stbenjam added a commit that referenced this pull request Nov 14, 2014
Added recognition of Scientific Linux
@stbenjam stbenjam merged commit 673865b into theforeman:master Nov 14, 2014
@ekohl
Copy link
Member

ekohl commented Nov 14, 2014

Maybe my intention was to add SL then, but didn't complete it past copy-pasting. Thanks @jcpunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants