-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7882 Added support for OracleLinux #41
Conversation
@soumentrivedi do you think we should add a basic test for this similar to https://github.com/Katello/puppet-katello/blob/master/spec/classes/katello_spec.rb#L5 ? |
Is there a reason to add these individually? There's a lot of Enterprise clones that may just work with Katello, and you can just catch them all:
|
hello guys, would it be safe to assume that this pull request is just awaiting to be merged as I would like to start using the changes done in this fork of the branch for my tests till v2.0.1 is released and available through standard yum repositories? |
} | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds trailing whitespace
Everything looks good to me. ACK and merging after the trailing whitespace fix. |
@ehelms I have done the changes and it is awaiting pull. |
👍 |
In #44 I did some further cleaning and included these changes. |
@ehelms yes, this PR in itself is good, but I was annoyed by the duplication of logic in |
@soumentrivedi Thanks! Merging. |
Fixes #7882 Added support for OracleLinux
Following on from earlier pull request #40 this is a clean and complete request now.