Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7882 Added support for OracleLinux #41

Merged
merged 1 commit into from
Oct 15, 2014

Conversation

soumentrivedi
Copy link
Contributor

Following on from earlier pull request #40 this is a clean and complete request now.

@ehelms
Copy link
Member

ehelms commented Oct 11, 2014

@soumentrivedi do you think we should add a basic test for this similar to https://github.com/Katello/puppet-katello/blob/master/spec/classes/katello_spec.rb#L5 ?

@stbenjam
Copy link
Member

Is there a reason to add these individually? There's a lot of Enterprise clones that may just work with Katello, and you can just catch them all:

$::osfamily == "RedHat" and $::operatingsystem != "Fedora"

@soumentrivedi
Copy link
Contributor Author

Thanks @stbenjam I have changed that logic as it makes more sense. Also @ehelms I have updated the tests to include a context for OEL. Also squashed the commits into one :)

@soumentrivedi
Copy link
Contributor Author

hello guys, would it be safe to assume that this pull request is just awaiting to be merged as I would like to start using the changes done in this fork of the branch for my tests till v2.0.1 is released and available through standard yum repositories?

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds trailing whitespace

@ehelms
Copy link
Member

ehelms commented Oct 14, 2014

Everything looks good to me. ACK and merging after the trailing whitespace fix.

@soumentrivedi
Copy link
Contributor Author

@ehelms I have done the changes and it is awaiting pull.

@ekohl
Copy link
Member

ekohl commented Oct 15, 2014

👍

@ekohl
Copy link
Member

ekohl commented Oct 15, 2014

In #44 I did some further cleaning and included these changes.

@ehelms
Copy link
Member

ehelms commented Oct 15, 2014

@ekohl so both of these PRs are not needed correct? Your preference would be the style of #44 ?

@ekohl
Copy link
Member

ekohl commented Oct 15, 2014

@ehelms yes, this PR in itself is good, but I was annoyed by the duplication of logic in install.pp.

@ehelms
Copy link
Member

ehelms commented Oct 15, 2014

@soumentrivedi Thanks! Merging.

ehelms added a commit that referenced this pull request Oct 15, 2014
Fixes #7882 Added support for OracleLinux
@ehelms ehelms merged commit e85583d into theforeman:master Oct 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants