Fixes #8079 - Can update docker tags in repository #136
Conversation
|
can you write a test? |
| # @param [Hash] tags for an image in the following format | ||
| # the [{:image_id => <image hash>, :tag =>"value"}] | ||
| # @return [RestClient::Response] | ||
| def update_docker_tags(repo_id, tags) |
There was a problem hiding this comment.
Missing documentation for the repo_id param
|
Well dont have a nice way to test this. Because we do not have a way to sync docker repos. I have created an issue that should address this http://projects.theforeman.org/issues/8102 |
|
I'm okay with skipping a test, but some need to be added before the docker work is complete |
|
Still my comment to be addressed. And out of curiosity, why can't we sync a docker repo? |
|
@ehelms updated as per your comment. Docker sync test for runcible is on way next. Discussing with bcourt on how to implement a dummy docker repo on local host similar to the way we do yum. If it turns out to be too complicated we'll resort to what puppet does point to @daviddavis puppet repos on fedorapeople. |
|
@ehelms i don't think we can't, its juts that none of the previous docker PRs added any live tests, which was unfortunate. |
|
:/ ACK |
|
@ehelms @jlsherrill minor corrections. The CRUD repos has been tested live. Its just that sync has not been and hence the docker images have not been tested . I have an issue here to address that -> http://projects.theforeman.org/issues/8102 |
|
ACK |
Fixes #8079 - Can update docker tags in repository
No description provided.