Fixes #37399 - Container gateway needs to send ACCEPT headers from podman to Pulp #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
force-pushed
the
37399-pass-headers-to-pulp
branch
2 times, most recently
from
c0229a6
to
9252988
Compare
ianballou
force-pushed
the
37399-pass-headers-to-pulp
branch
from
9252988
to
ed1c99f
Compare
sjha4
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, pulling content with the newer pulp-container 2.19 will fail because Pulp will think the container gateway has no manifest acceptance capabilities, thus triggering a 404.
The change also allows errors from Pulp to be returned properly.
To test, try pulling any container content that's on the smart proxy.
To test the proper erroring, try syncing some content and then deleting it in Pulp. This will make the container gateway think that it has repositories synced when it really doesn't, so it should send requests to Pulp for content that doesn't exist.