Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide defunct restaurants #107

Open
KatrinaHoffert opened this issue Mar 12, 2015 · 1 comment
Open

Hide defunct restaurants #107

KatrinaHoffert opened this issue Mar 12, 2015 · 1 comment

Comments

@KatrinaHoffert
Copy link
Owner

Anything that hasn't been inspected in, say, 2 years (should be configurable) shouldn't be shown. Can be done at the model level. We only need to prevent them from being listed in the multi-map or location selection.

Issue: location selection isn't aware of inspections.

Possibility: create a "defunct" column in the DB and set this in the CSV parser, which is aware of the issues (parser could quickly look at all the inspection dates, sort them, grab the latest, and check if it meets some threshold).

@KatrinaHoffert
Copy link
Owner Author

I think this should be done in M5. It's not that hard to do. Issue is that we'd need to create more complicated queries and use caching. Or we could do what I mentioned in the post, which is a cleaner method. Still wouldn't be that hard, though.

I lean towards the CSV parser approach (a "defunct" column). It's more efficient without the need for caching.

Why is this important? Because we really want to avoid showing users locations that aren't there anymore. And a defunct column is more versatile because it could be set manually when some place closes (no current plans to do so, but it's more future proof).

@garmu garmu modified the milestones: Back Burner, Milestone 5 Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants