Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] [Feature request] Delete confirmation / 'sticky' tag #18

Closed
bushrang3r opened this issue Sep 18, 2021 · 6 comments
Closed

[Android] [Feature request] Delete confirmation / 'sticky' tag #18

bushrang3r opened this issue Sep 18, 2021 · 6 comments

Comments

@bushrang3r
Copy link

One thing that might save important items from being accidentally deleted is a confirmation dialogue when deleting tagged and pinned items.
Or, maybe add a special tag, e.g. 'sticky', that if attached to a clipped item, throws a confirmation dialogue on deletion.

@KaustubhPatange
Copy link
Owner

I mean you can still undo the deleted items, right? Is it necessary?

@bushrang3r
Copy link
Author

bushrang3r commented Sep 19, 2021

Yes, that's two taps to delete, and one more within a couple of seconds to undo, otherwise it's gone.
I like the swipe delete but there's no undo for that.

I've seen a good solution on the XDA forums app.
You can swipe across a little which reveals the delete button, and taking your finger off leaves the delete button visible, and if you still want to delete, you tap it. Then if you show the undo option after that, it would be like combining the hold and select delete option, and the swipe to delete option into one solution.
OR,
maybe just do that for pinned/tagged items so that you have the extra safety for if you accidentally swipe away something important.

@KaustubhPatange
Copy link
Owner

KaustubhPatange commented Sep 19, 2021

I'll add the undo button for swipe delete.

I have an idea so when you delete an item the undo snackbar will show but it won't hide unless you touch anywhere on the screen except the bar itself. Thus it will be persisted indefinitely until the user touches anywhere on the screen.

KaustubhPatange added a commit that referenced this issue Sep 19, 2021
@bushrang3r
Copy link
Author

Great! Thanks!

And, yes! Great idea! I'd appreciate a persistent undo button.

@KaustubhPatange
Copy link
Owner

Hey, this feature is added you can test it & give me early feedback before merging into the final update. Here's how you can do that.

@bushrang3r
Copy link
Author

Works great for me! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants