New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating suggestion bubble & Slack #21
Comments
Yeah, sometimes it dismisses immediately because it relies on focus change. The behavior you are expecting is not a bug but the way the feature was designed. Think this way, how annoying it would be to constantly show a bubble on the screen even when a user doesn't want it (they will disable the suggestions). Also if there is something like what you describe to constantly show bubble until the user taps a suggestion. What if I changed my mind in between and decided to complete the text ignoring the suggestions, according to your use case I first have to tap the cancel button & then tap the edit box to continue typing, this is horrific in terms of design. A user must be able to go back to its original state as quickly as possible (hence the focus change). Also, It is necessary to close the dialog as well as it will annoy the user while writing text in the edit box. The design chose was when the bubble is expanded a focus change listener is added to it which will detect if the window loses any focus, if so it will close the bubble. This is by far approved by a lot of testers I talked with. Also typing a message means losing focus to the bubble window which should close it since the user expects a distraction-free environment while writing. Hopefully this answers your questions. Let me know! |
Thanks for the quick reply. |
I said in slack it dismisses is a bug & the rest of the things I explained. I'll try to fix it since slack is always sketchy on its IME & steals unwanted focus whenever it goes out of focus. Can't understand the reason this technique works on all other apps except Slack. If I had any success I'll let you know! |
You said it's not a bug. |
Hey, your issue seems to be fixed from my side. Test the app after the CI build (how-to) before it is merged in the final update. |
Yes, excellent. It's working for me now. |
Please complete the following information:
Describe the Bug:
When using Slack, if I tap on the floating bubble, the suggestions open and then disappear immediately. This only happens when typing a message.
When I tap on the bubble when typing in the search function in Slack, the suggestions can be selected via the bubble as usual.
I have only observed this behavior when using Slack.
Expected Behavior:
The suggestions should open, and stay open, after tapping on the suggestion bubble, until a suggestion is tapped.
Logs below:
2021-09-30-11-50-12.txt
The text was updated successfully, but these errors were encountered: