Deleted entries persist on restart

[bushrang3r]

Platform - Android
App Version - 1.2.1
Affected Device(s) - OnePlus 7t (Android 11)

Describe the Bug:

Deleted entries do not disappear from the suggestions or from the app on next restart. I have to make the same deletions two or three times and restart the app between each deletion for them to disappear.

Expected Behavior:

Deleted entries should be gone after deleting them the first time.
I have logs of this but I don't know if they will be helpful.

2021-12-04-Xclipper.txt

[KaustubhPatange]

Like I said if you see a SnackBar for undo button it means the items are not deleted. You need to interact with the screen to remove SnackBar so the items are permanently deleted.

[bushrang3r]

I don't think that's the issue.
When I was testing, I would multi-select and delete about 10 items, then close and open the app again, and the items were still there. Then I opened and closed it a couple more times, and finally, while I was just looking at the list, they disappeared. It took a while for them to disappear, although, it doesn't happen all the time. That's what's in the log I attached above.
I'm trying to reproduce it now. If I can, I'll let you know.

[KaustubhPatange]

The log doesn't provide any details only the object allocation mapping (doesn't correspond to anything useful).

Are you using synchronisation feature? Because it might take time to delete the items from Firebase (sometimes). I'm aware of these issue and will be working on it soon. Is these related because without sync feature everything is working fine!

[bushrang3r]

Yes, I thought the logs might not be useful.
No, I'm not using the sync feature.
I'll keep testing it.

[KaustubhPatange]

Send a screen record if you can reproduce the issue!

[bushrang3r]

I just had an app crash related to this. A message said the stack trace was sent to your server.

[KaustubhPatange]

The crash will be aggregated and will be visible after 24 hours. If you have a stack trace text like a screenshot of the text you can send me here to quickly analyze it.

[bushrang3r]

[KaustubhPatange]

Seems like an issue with the suggestions list. I'll dig more & find out the real cause! Thanks for the info.

[KaustubhPatange]

Some additional questions, how many items are you deleting at once to reproduce this crash?

[bushrang3r]

The crash happened when I multi-selected and deleted many at once. It would have been about 10 or 15 items.

[KaustubhPatange]

I'm very busy this week, I've tried to fix this issue manually & have attached a zipped apk release of the app for you to test. Just extract & install it to see if it works. Also, this is an experimental build you may get some other crashes but see if your original issue resolves or not.

Get here, app-release-zip.zip.

[bushrang3r]

Thanks!

Before I installed that experimental build, I started my installed version to try deleting some more items by swiping them away. I got a new bug that I hadn't seen before. (See the attached screenshot.) When I swipe away the items, the red color that replaces the deleted items doesn't disappear. It stays on the screen, even when restarting the app.

After that, I installed the experimental build you linked above. I have started using it and it seems to be working well. I'm not getting the bug from this post, or the bug I reported in my previous post. I'll keep testing and let you know if I find any problems.

[KaustubhPatange]

So the error that you have shown in above image does not happen in the experimental build? Seems strange!

[bushrang3r]

I haven't seen it happen yet. It may still happen as I keep testing.
The error above doesn't constantly happen with the previously installed (latest) version. It comes and goes.
Could it be something related to OnePlus devices?

Also, after I update my ROM, should I rerun the adb commands?

[KaustubhPatange]

I don't thing so it is related to oneplus device but have to figure out why? How much i.e no of clips you have currently or had when you faced this issue?

I mean if in the app settings it tells you to enable the improve detection setting, then you have to rerun the commands otherwise there is no need!

[bushrang3r]

I've created my own tag called 'important' and I have tagged 11 items with it that I don't delete. When other items reach about 10 or 20 more, I swipe delete them, or multi select them and tap the delete button.

One bug I'm seeing in the experimental build is that there is always a new blank item at the top of the list.
How to reproduce:

1. Start the app and delete that blank item at the top
2. Scroll the list to permanently delete the item
3. Swipe the app away
4. Tap on the app to open it again
5. The new blank item is there again

[KaustubhPatange]

Wait, I'm not seeing that blank item. Did you copy something i.e blank or empty text? The issue is not reproducible on my side. Although the blank item shouldn't get copied in the first place.

[bushrang3r]

I just started the app again and it's not happening now.
I reproduced this bug over and over (5, 6, 7 times) in the steps 1 to 6 that I wrote above without doing anything in between, and now when I just tried again, it's not happening. Very strange.

[KaustubhPatange]

What kind of sorcery is this? I'll keep looking if this reproduces!

[bushrang3r]

Today I had a couple more bugs.

1. When I highlight and copy 2,3,4,5 words quickly, none of them, or only one, gets copied into the app.
   I tried force closing the app, restarting, and trying again, same problem.

2. Also, the bubble didn't appear with the keyboard, so I go into the settings and toggle off/on the bubble setting, but it still didn't appear with the keyboard.

So, I restarted the phone and now both problems are fixed.

These bugs tend to happen after I haven't used the phone for a few hours. Do you think it could be related to deep sleep?

[KaustubhPatange]

1. You should give a gap of 1 second at least to process for the clipboard copy detect action. If something like this happens disable the accessibility service from the settings & enable it again!
2. Seems like accessibility is getting an internal crash. Might have to look at why is that?

[KaustubhPatange]

Try this experimental build & see if it works & solves your issue?

Also, if suppose the copy function or bubble is not working then first check in your device settings > Accessibility > XClipper or similar pathway & see if the text there is written something like "This service is not working/malfunctioning" & then stop & start the service to see if it fixes.

Get the build here, app-debug.apk.zip

[bushrang3r]

Ok, thanks. Understood.

I unzipped app-dubug build above and tried to install but it fails. Do I need to uninstall the previous experimental build first?

[KaustubhPatange]

Try this build generated from Actions https://github.com/KaustubhPatange/XClipper/suites/4715845943/artifacts/129533111

[bushrang3r]

Thanks. That one worked.

[KaustubhPatange]

Hey, I've fixed the 3 listed issues in this issue,

1. The one with the suggestions items is still present even after deleting.
2. Deleting multiple items still persist on restart (original issue).
3. Swipe to delete item will now be fast so no such red background issue.

Try the fix by following this guide.

I can now work on new features & improvements since the main architecture migration is complete.

[bushrang3r]

Great! Thanks. I'm testing it now.

[KaustubhPatange]

Does the list of issues mentioned here reappear in the build?

[bushrang3r]

No, I think these issues are all solved.
Thank you sir!

[KaustubhPatange]

Ok great!