Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KHI CAD Data Disclaimer to README #20

Merged
merged 4 commits into from
May 30, 2019

Conversation

matsui-hiro
Copy link
Member

LIcense for ** _ description is BSD.
But, there is a disclaimer of KHI CAD Data.
Therefore, URDF STL files need to be compliant.
I added it to the README.

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented May 27, 2019

The license tag in package manifests can occur multiple times in a manifest (see REP 140).

Perhaps adding a second license tag for this would be more visible (contents of license tags is shown on the ROS wiki pages for instance).

Example:

  <license>KHI CAD license (mesh data, see readme)</license>

or if using format 3 (REP 149), you could consider placing the license text in a separate file and refer to it from the license tag (path is relative to the package.xml):

  <license file="khi_cad_license.txt">KHI CAD license (mesh data)</license>

@matsui-hiro
Copy link
Member Author

@gavanderhoorn:Thank you for your suggestion !

I adopt the upper idea.

  <license>KHI CAD license (mesh data, see readme)</license>

This KHI licese tag will be added to package.xml of *** _ description .

README.md Outdated Show resolved Hide resolved
@d-nakamichi d-nakamichi merged commit 542096c into Kawasaki-Robotics:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants