New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to build release package on i386/arm #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
force-pushed
the
armhf
branch
5 times, most recently
from
May 21, 2019 22:16
126e318
to
fa41278
Compare
…on the docker system. To solve this issue, we use CMAKE_LIBRARY_ARCHITECTURE to find current target machine
d-nakamichi
reviewed
May 29, 2019
yes, running arm vm is slow compared to the native architecture and I think
we should add "--skip-test" option to 'generate_prerelease_script ' in
future.
…--
◉ Kei Okada
2019年5月29日(水) 10:41 Daisuke NAKAMICHI <notifications@github.com>:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#19 (comment)>
:
> @@ -36,6 +41,8 @@ install:
- cp -R $TRAVIS_BUILD_DIR $JOB_PATH/catkin_workspace/src/
# generate the script to run a pre-release job for that target and repo
- generate_prerelease_script.py https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml $ROS_DISTRO_NAME default $OS_NAME $OS_CODE_NAME $ARCH --output-dir $JOB_PATH
+ # skip build and test for ARM containers
+ - if [[ "$ARCH" == "arm"* ]]; then sed -i '/build and test/i mkdir -p $WORKSPACE/catkin_workspace/test_results; exit 0' $JOB_PATH/prerelease_build_underlay.sh; fi
What is the reason adding this?
Is it for timeout of travis?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AADYNXF5YAWEYCT63REO6JDPXXNL7A5CNFSM4HOGKSYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZ57G5A#pullrequestreview-243004276>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADYNXBMGBLSQ7JCSWS3BSDPXXNL7ANCNFSM4HOGKSYA>
.
|
d-nakamichi
approved these changes
May 31, 2019
matsui-hiro
approved these changes
May 31, 2019
Thank you! @k-okada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uname -p
https://cmake.org/cmake/help/v3.1/variable/CMAKE_SYSTEM_PROCESSOR.html and. https://cmake.org/cmake/help/v3.1/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html#variable:CMAKE_HOST_SYSTEM_PROCESSORARCH
value in .travis file