Fix email address #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Functionality conceptually complete (haven't tested it yet) * Trying to figure out how to test this with ERT before I QA it.
Incorrect order of arguments causes wrong type argument error in scala-indent:indent-line. Swapping argument order fixes the error reported by @jj1uzh [here](Kazark#1 (comment)).
|
Fill me in here on how this will fix it---I think my head is not in the details. |
I had to amend the commit with git commit --amend --author --> It used my work computer's hostname because I forgot to setup git when I first did the work. Now it's got the correct address on the commit. |
|
A merge won't fix that. Amending a commit creates a new commit. The old one will still be there. I may have to do some magic to rebase the commits and see if I can fix the metadata and force-push them. |
|
Thanks for the attempt---I will see if I can fix this with a rebase on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the email address on 87fefe3 so that this is under the CLA