fix credo

KazuCocoa · Nov 20, 2018 · 472bfd4 · 472bfd4
1 parent f617128
commit 472bfd4
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 28 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -11,4 +11,5 @@ sudo: false
 
 script:
   - MIX_ENV=test mix do compile --warnings-as-errors
+  - mix credo --strict
   - mix test --cover
diff --git a/lib/http_proxy/handle.ex b/lib/http_proxy/handle.ex
@@ -14,11 +14,11 @@ defmodule HttpProxy.Handle do
   alias Plug.Conn
   alias Plug.Cowboy, as: PlugCowboy
 
+  alias HttpProxy.Play.Body, as: PlayBody
   alias HttpProxy.Play.Data
-  alias HttpProxy.Record.Response, as: Record
-  alias HttpProxy.Play.Response, as: Play
   alias HttpProxy.Play.Paths, as: PlayPaths
-  alias HttpProxy.Play.Body, as: PlayBody
+  alias HttpProxy.Play.Response, as: Play
+  alias HttpProxy.Record.Response, as: Record
 
   alias JSX
 

diff --git a/lib/http_proxy/play/data.ex b/lib/http_proxy/play/data.ex
@@ -4,8 +4,8 @@ defmodule HttpProxy.Play.Data do
   The structure gets data via HttpProxy.Play.Response.play_responses.
   """
 
-  alias HttpProxy.Play.Response, as: HttpProxyResponse
   alias HttpProxy.Agent, as: ProxyAgent
+  alias HttpProxy.Play.Response, as: HttpProxyResponse
 
   @responses :play_responses
 
@@ -34,11 +34,9 @@ defmodule HttpProxy.Play.Data do
          "response" => %{"body" => "<html>hello world 3</html>", "cookies" => %{},
            "headers" => %{"Content-Type" => "text/html; charset=UTF-8",
              "Server" => "GFE/2.0"}, "status_code" => 201}}
-
-
   """
   @spec responses() :: binary
-  def responses(), do: response(ProxyAgent.get(@responses))
+  def responses, do: response(ProxyAgent.get(@responses))
 
   defp response(nil) do
     ProxyAgent.put(@responses, HttpProxyResponse.play_responses())

diff --git a/lib/http_proxy/play/paths.ex b/lib/http_proxy/play/paths.ex
@@ -4,8 +4,8 @@ defmodule HttpProxy.Play.Paths do
   The structure gets paths as list via HttpProxy.Play.Response.play_paths.
   """
 
-  alias HttpProxy.Play.Response
   alias HttpProxy.Agent, as: ProxyAgent
+  alias HttpProxy.Play.Response
 
   @type path :: binary
   @type paths :: [path]

diff --git a/lib/http_proxy/play/response.ex b/lib/http_proxy/play/response.ex
@@ -18,14 +18,14 @@ defmodule HttpProxy.Play.Response do
                       MapSet.new()
                     )
 
-  alias HttpProxy.Utils.File, as: HttpProxyFile
   alias HttpProxy.Play.Data
+  alias HttpProxy.Utils.File, as: HttpProxyFile
 
   @spec play?() :: boolean
   def play?(), do: Application.get_env(:http_proxy, :play, false)
 
   @spec play_responses() :: [response_body] | []
-  def play_responses() do
+  def play_responses do
     case play?() do
       true ->
         gen_response()
@@ -35,7 +35,7 @@ defmodule HttpProxy.Play.Response do
     end
   end
 
-  defp gen_response() do
+  defp gen_response do
     HttpProxyFile.get_mapping_path()
     |> HttpProxyFile.json_files!()
     |> Enum.reduce([], fn path, acc ->

diff --git a/lib/http_proxy/supervisor.ex b/lib/http_proxy/supervisor.ex
@@ -4,8 +4,8 @@ defmodule HttpProxy.Supervisor do
   """
 
   use Supervisor
-  alias HttpProxy.Handle
   alias HttpProxy.Agent, as: ProxyAgent
+  alias HttpProxy.Handle
 
   def start_link, do: Supervisor.start_link(__MODULE__, :ok, name: __MODULE__)
 

diff --git a/lib/http_proxy/utils/file.ex b/lib/http_proxy/utils/file.ex
@@ -47,7 +47,7 @@ defmodule HttpProxy.Utils.File do
       "test/data/mappings"
   """
   @spec get_export_path(integer | binary) :: String.t()
-  def get_export_path(), do: export_path() <> "/" <> mapping_files()
+  def get_export_path, do: export_path() <> "/" <> mapping_files()
 
   def get_export_path(port) when is_integer(port),
     do: export_path() <> "/" <> Integer.to_string(port) <> "/" <> mapping_files()
@@ -56,7 +56,7 @@ defmodule HttpProxy.Utils.File do
     do: export_path() <> "/" <> port <> "/" <> mapping_files()
 
   @spec get_export_binary_path(integer | binary) :: String.t()
-  def get_export_binary_path(), do: export_path() <> "/" <> response_files()
+  def get_export_binary_path, do: export_path() <> "/" <> response_files()
 
   def get_export_binary_path(port) when is_integer(port),
     do: export_path() <> "/" <> Integer.to_string(port) <> "/" <> response_files()
@@ -65,15 +65,15 @@ defmodule HttpProxy.Utils.File do
     do: export_path() <> "/" <> port <> "/" <> response_files()
 
   @spec get_response_path() :: String.t()
-  def get_response_path(), do: play_path() <> "/" <> response_files()
+  def get_response_path, do: play_path() <> "/" <> response_files()
 
   @spec get_mapping_path() :: String.t()
-  def get_mapping_path(), do: play_path() <> "/" <> mapping_files()
+  def get_mapping_path, do: play_path() <> "/" <> mapping_files()
 
-  defp export_path(), do: Application.get_env(:http_proxy, :export_path, "default")
-  defp play_path(), do: Application.get_env(:http_proxy, :play_path, "default")
-  defp response_files(), do: %HttpProxyFile{}.response_files
-  defp mapping_files(), do: %HttpProxyFile{}.mapping_files
+  defp export_path, do: Application.get_env(:http_proxy, :export_path, "default")
+  defp play_path, do: Application.get_env(:http_proxy, :play_path, "default")
+  defp response_files, do: %HttpProxyFile{}.response_files
+  defp mapping_files, do: %HttpProxyFile{}.mapping_files
 
   @doc ~S"""
   Generate json file name with `:rand.uniform`

diff --git a/test/http_proxy/http_test.exs b/test/http_proxy/http_test.exs
@@ -4,8 +4,8 @@ defmodule HttpProxy.HttpTest do
   use ExUnit.Parameterized
   use Plug.Test
 
-  alias HttpProxy.TestHelper, as: TestHelper
   alias HttpProxy.Handle, as: HttpProxyHandle
+  alias HttpProxy.TestHelper, as: TestHelper
 
   test "files are created in record mode" do
     File.rm_rf!(Application.get_env(:http_proxy, :export_path))
@@ -45,15 +45,15 @@ defmodule HttpProxy.HttpTest do
         {:error, _} -> []
       end
 
-    assert Enum.count(exported_files) == 0
+    assert exported_files == []
 
     exported_body_files =
       case File.ls("test/example/8080/__files") do
         {:ok, files} -> files
         {:error, _} -> []
       end
 
-    assert Enum.count(exported_body_files) == 0
+    assert exported_body_files == []
   end
 
   test_with_params "play responses agains particular request", fn method, uri, expected_body ->

diff --git a/test/http_proxy/play/response_test.exs b/test/http_proxy/play/response_test.exs
@@ -2,9 +2,10 @@ defmodule HttpProxy.Play.ResponseTest do
   use ExUnit.Case, async: true
   use ExUnit.Parameterized
 
+  alias HttpProxy.Play.Response, as: Response
   alias JSX
 
-  doctest HttpProxy.Play.Response
+  doctest Response
 
   test "tewrong diff in request" do
     json = ~s"""
@@ -25,7 +26,7 @@ defmodule HttpProxy.Play.ResponseTest do
     """
 
     assert_raise ArgumentError, "Response jsons must include arrtibute: path_pattern path method ", fn ->
-      json |> JSX.decode! |> HttpProxy.Play.Response.validate
+      json |> JSX.decode! |> Response.validate
     end
   end
 
@@ -49,7 +50,7 @@ defmodule HttpProxy.Play.ResponseTest do
     """
 
     assert_raise ArgumentError, "Response jsons must include arrtibute: body_file body ", fn ->
-      json |> JSX.decode! |> HttpProxy.Play.Response.validate
+      json |> JSX.decode! |> Response.validate
     end
   end
 
@@ -74,7 +75,7 @@ defmodule HttpProxy.Play.ResponseTest do
     """
 
     assert_raise ArgumentError, "Response jsons must include arrtibute: path_pattern path ", fn ->
-      json |> JSX.decode! |> HttpProxy.Play.Response.validate
+      json |> JSX.decode! |> Response.validate
     end
   end
 
@@ -100,7 +101,7 @@ defmodule HttpProxy.Play.ResponseTest do
     """
 
     assert_raise ArgumentError, "Response jsons must include arrtibute: body_file body ", fn ->
-      json |> JSX.decode! |> HttpProxy.Play.Response.validate
+      json |> JSX.decode! |> Response.validate
     end
   end
 end