Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out console.log #8

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

marcofugaro
Copy link
Contributor

@marcofugaro marcofugaro commented Jan 21, 2020

Close #6, it's really annoying when using the library.

I didn't generate the .min.js because there is no script in the build pipeline to generate it.

@Kcnarf Kcnarf merged commit 01d203d into Kcnarf:master Jan 22, 2020
@Kcnarf
Copy link
Owner

Kcnarf commented Jan 22, 2020

Close #6, it's really annoying when using the library.

I didn't generate the .min.js because there is no script in the build pipeline to generate it.

Before commiting, `yarn precommit' builds the minified file (after executing tests and building basic non-minified files).

This is available at the end of the README, but it seems it is not obvious. Can you give me some advices in order to make it more explicit.

@marcofugaro
Copy link
Contributor Author

@Kcnarf I would move the minifying script in the postbuild script in the package.json scripts. This will get executed after the build command has finished

@marcofugaro
Copy link
Contributor Author

@Kcnarf also, it would be great if you'd publish a new version of this library on npm with those fixes 🙂

@Kcnarf
Copy link
Owner

Kcnarf commented Jan 22, 2020

@Kcnarf also, it would be great if you'd publish a new version of this library on npm with those fixes 🙂

new version 2.0.1 is available on NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of console.log in production
2 participants