New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nette/DI 3.0.2 compatiblity #27
Conversation
There is BC in this release https://github.com/nette/di/releases/tag/v3.0.2
Ping @enumag . |
I don't really understand. Is there a BC break in 3.0.2 specifically (as in everything is fine with 3.0.1)? If so then it should be reported to nette/di and reverted. Or is this a problem with 3.0.0+? |
I believe this is the change in nette/di that breaks it: nette/di@v3.0.1...v3.0.2#diff-6682ea383870132c0a5bfc2133f557d1R456 Not really sure it's a BC as it's pretty low level function... |
The Resolver class is marked as |
Is ok to pick these two static methods from DI Resolver class and put them into this package?
|
Hmm that's not really something we should duplicate... ok maybe I should merge it as is then. Can you please verify that your fix doesn't break Nette 3.0.0 and 3.0.1? |
Good point - not working for those versions. Is ok to set a minimal version in the composer? |
Co-Authored-By: Jáchym Toušek <enumag@gmail.com>
I guess so. Do it. |
done |
There is BC in this release
https://github.com/nette/di/releases/tag/v3.0.2