Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching \Throwable leads to problems when try to render it. #61

Closed
wants to merge 5 commits into from

Conversation

kratkyzobak
Copy link
Contributor

Symfony\Console\Application::renderException(\Exception $o, OutputInterface $output) is not compatibile with catching \Throwable.

Modified Kdyby\Console\Application::handleException to use own (very simple) render method (and Tracy to store error in log, as usual).

@fprochazka
Copy link
Member

Thank you!

@trejjam
Copy link

trejjam commented May 8, 2017

I found that Symfony solve this decorating by Symfony\Component\Debug\Exception\FatalThrowableError so they can use same renderException for render.
Would you like change it this way?

@fprochazka
Copy link
Member

@trejjam yes, I think that's a good idea! I will do that :)

@fprochazka
Copy link
Member

7e9eef0

@trejjam
Copy link

trejjam commented May 13, 2017

Wow! Thank you

One small question, could you create new tag for this repo?

@fprochazka
Copy link
Member

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants