Fixed faulty loop management when unsubscribing listeners #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the nested foreach loop.
It iterates over all listeners for the given event, searching for the index of the subscriber, that should be unsubscribed for this event. When the subscriber in the current iteration isn't the one we're looking for, it should continue to the next one. However there's
continue(2)
instead, which causes all other subscribers to be skipped and the loop continues with next event.The result is that, if the subscriber is first in the array of subscribers for a given event, it's successfully unsubscribed as expected. If it's not the first, then it won't be unsubscribed because the whole array will be skipped.
This commit fixes the bug, changing
continue(2)
tocontinue
to properly continue to another subscriber in the array.