Skip to content

Commit

Permalink
Updated testStrictEmail() test
Browse files Browse the repository at this point in the history
  • Loading branch information
DepkaCZ committed Jul 12, 2018
1 parent d562844 commit 8e5ac95
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/DI/ValidatorExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Nette;
use Nette\DI\Compiler;
use Nette\Utils\Validators;

use Symfony\Component\Validator\Constraints\Email;


/**
Expand Down Expand Up @@ -84,7 +84,7 @@ public function loadConfiguration()
if ($config['strictEmail'] !== NULL) {
Validators::assertField($config, 'strictEmail', 'boolean');
trigger_error('`strictEmail` configuration option is deprecated, use `emailValidationMode` instead.', E_USER_DEPRECATED);
$config['emailValidationMode'] = \Symfony\Component\Validator\Constraints\Email::VALIDATION_MODE_LOOSE;
$config['emailValidationMode'] = Email::VALIDATION_MODE_LOOSE;
}

Validators::assertField($config, 'emailValidationMode', 'string');
Expand Down
9 changes: 5 additions & 4 deletions tests/KdybyTests/Validator/Extension.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ class ExtensionTest extends Tester\TestCase
public function strictEmailDataProvider()
{
return [
[[], FALSE],
[[__DIR__ . '/config/strict-email.neon'], TRUE],
[[__DIR__ . '/config/non-strict-email.neon'], FALSE],
[[], 'loose'],
[[__DIR__ . '/config/strict-email.neon'], 'strict'],
[[__DIR__ . '/config/non-strict-email.neon'], 'loose'],
];
}

Expand All @@ -138,7 +138,8 @@ class ExtensionTest extends Tester\TestCase
$validator = $factory->getInstance(new \Symfony\Component\Validator\Constraints\Email());
Tester\Assert::type('Symfony\Component\Validator\Constraints\EmailValidator', $validator);

$property = new \ReflectionProperty('Symfony\Component\Validator\Constraints\EmailValidator', 'isStrict');
$property = new \ReflectionProperty('Symfony\Component\Validator\Constraints\EmailValidator', 'defaultMode');

$property->setAccessible(TRUE);
Tester\Assert::same($strict, $property->getValue($validator));
}
Expand Down
2 changes: 1 addition & 1 deletion tests/KdybyTests/Validator/config/non-strict-email.neon
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
validator:
strictEmail: false
emailValidationMode: 'loose'
2 changes: 1 addition & 1 deletion tests/KdybyTests/Validator/config/strict-email.neon
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
validator:
strictEmail: true
emailValidationMode: 'strict'

0 comments on commit 8e5ac95

Please sign in to comment.