class KeyOclExpressionTranslator too large

[wadoon]

This issue was created at git.key-project.org where the discussions are preserved.

---

• Mantis: MT-116

• Submitted on: 2002-12-12 by (at)giese

• Updated: 2006-12-21

• Assigned to: (at)dlohner

Description

The .java file for
...ocl.ocldltranslator.KeyOclExpressionTranslator
has 324kByte in over 8800 lines. There are >50 methods,
of which only 20 have JavaDoc comments. Three of the methods are over 1500 lines long.

There is bound to be at least one bug here, and nobody will ever be able to fix it.

Files

Notes

(at)rbubel at 2003-11-06

Will be redesigned with the JML support, until the I suspend this bug.

(at)giese at 2005-04-07

Sooooo.... now we have JML support and the KeyOclExpressionTranslator is still there in all its splendour!

(at)rbubel at 2005-04-07

You got me ;-) Yes, this issue is already marked here:
http://i12www.ira.uka.de/~klebanov/keywiki/index.cgi?KeYOneZeroUpdated
and will be initiated soon.

(at)aroth at 2005-10-21

Is being attacked by Denis and Benjamin

(at)dlohner at 2006-07-05

The Class KeYOclExpressionTranslator and the whole package de.uka.ilkd.key.ocldltranslator is not used by the new OCLDL-Translation. So this package is only there for using the old POs.

The new Translation is (mainly) located in
de.uka.ilkd.key.parser.ocl
(few things are in de.uka.ilkd.key.ocldltranslation)

(at)klebanov at 2006-07-19

Denis, resolution, please. Can you also please look at and say something about #265?

(at)dlohner at 2006-12-21

since version 0.2417 the old OCL-Translator as well as the tudresden-Parser aren't anymore on the main branch.
So this bug should also be resolved, as there is no class KeyOclExpressionTranslator now :)

(at)giese at 2006-12-21

This one has been around so long, it might haunt the system even after the class is gone... I'll tentatively close it, but if you see any new classes with +1000 LOC methods, it's probably

*** THE CURSE OF KEYOCLEXPRESSIONTRANSLATOR ***

and this bug needs to be reopened :-D

History

• (at)rbubel -- (NORMAL_TYPE) 2003-11-06

• (at)rbubel -- (NORMAL_TYPE) 2003-11-06

• (at)rbubel -- (BUGNOTE_ADDED) 2003-11-06

• (at)giese -- (NORMAL_TYPE) 2005-04-07

• (at)giese -- (NORMAL_TYPE) 2005-04-07

• (at)giese -- (BUGNOTE_ADDED) 2005-04-07

• (at)rbubel -- (BUGNOTE_ADDED) 2005-04-07

• (at)aroth -- (BUGNOTE_ADDED) 2005-10-21

• (at)aroth -- (NORMAL_TYPE) 2005-10-21

• (at)klebanov -- (NORMAL_TYPE) 2006-06-29

• (at)dlohner -- (BUGNOTE_ADDED) 2006-07-05

• (at)dlohner -- (NORMAL_TYPE) 2006-07-05

• (at)dlohner -- (BUG_MONITOR) 2006-07-05

• (at)dlohner -- (BUG_UNMONITOR) 2006-07-05

• (at)klebanov -- (BUGNOTE_ADDED) 2006-07-19

• (at)dlohner -- (NORMAL_TYPE) 2006-12-21

• (at)dlohner -- (NORMAL_TYPE) 2006-12-21

• (at)dlohner -- (BUGNOTE_ADDED) 2006-12-21

• (at)giese -- (NORMAL_TYPE) 2006-12-21

• (at)giese -- (BUGNOTE_ADDED) 2006-12-21

Attributes

• Category: Code Quality
• Status: CLOSED
• Severity: MAJOR
• OS:
• Target Version:
• Resolution: FIXED
• Priority: NORMAL
• Reproducibility: ALWAYS
• Platform:
• Commit: None
• Build: 0.458
• Tags []
• Labels: ~Bug ~NORMAL

---

View in Mantis

---

Information:

• created_at: 2017-05-29T02:44:14.077Z
• updated_at: 2017-05-29T03:02:44.958Z
• closed_at: 2017-05-29T02:44:14.719Z (closed_by: )
• milestone:
• user_notes_count: 0