New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter #3034
Formatter #3034
Conversation
b91c974
to
f6a843a
Compare
My question would be: "Why writing/polishing the old Java pretty printing if libraries (e.g., google-java-format) are available?" |
It isn't just Java formatting it's Java formatting with jml asserts, method-frames, modalities and all the other stuff. |
Yes, and I would not built on top the Java parsing (which is realisied with Javac). I would go for the backend (the translation of Java AST into a document structure). |
What does that even mean? There exist classes to layout the remaining formulas for a given document width which are general enough to handle the Java part as well. |
c345c7e
to
96f36e9
Compare
This is done, the parsability problems are fixed. Making single line pretty printed terms more readable in the GUI is postponed until a later changed. |
Merge queue setting changed
* Removes most manual passing of line, column and replaces it with `Location` * [Fix issue dialog pointing to the wrong line (at least on Windows)](9894f7a) * Fix many positioning issues coming from 0-based/1-based columns/lines * Fix position information of block contracts and the like Blocking on #3034. There are some usages in the `PrettyPrinter` I won't fix since it's deleted there. [Artiweb](https://keyproject.github.io/artiweb/3049/)
The current Java formatter used in the sequent view is a mess. This PR tries to improve on that.
Current changes:
IOException
out of the interface of all pretty printing functions since it is never thrown.