Method names should not be created via VariableRenamer #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unp1
changed the title
|
Converted to draft. As I am not sure it won't have side-effects when parsing interactively. I have an idea for a safer change. |
|
Hi, this PR fixes the issue for method names and should be safe. We should think about using a different separator for variable names (i.e. not '_' which is not allowed as Java Identifier, e.g. §. Otherwise we need to store leading zeros in the index names. But that is for a different PR. Best regards, |
unp1
force-pushed
the
fixIssue1717
branch
2 times, most recently
from
78de5e0
to
f79fed5
Compare
Codecov Report
@@ Coverage Diff @@
## main #3231 +/- ##
============================================
+ Coverage 37.84% 37.85% +0.01%
- Complexity 16883 16892 +9
============================================
Files 2052 2052
Lines 125439 125443 +4
Branches 21215 21216 +1
============================================
+ Hits 47469 47487 +18
+ Misses 72117 72104 -13
+ Partials 5853 5852 -1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
unp1
force-pushed
the
fixIssue1717
branch
2 times, most recently
from
ac5885c
to
7924752
Compare
wadoon
approved these changes
Nov 2, 2023
unp1
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1717