Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OSS replaceKnown checks #3257

Closed
wants to merge 8 commits into from

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Aug 21, 2023

Extends #3256 by only doing a directed replaceKnown check after a rule app.

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #3257 (cf28d9c) into main (6c808a3) will increase coverage by 0.02%.
The diff coverage is 92.50%.

@@             Coverage Diff              @@
##               main    #3257      +/-   ##
============================================
+ Coverage     37.74%   37.77%   +0.02%     
- Complexity    16851    16870      +19     
============================================
  Files          2052     2052              
  Lines        125687   125750      +63     
  Branches      21234    21252      +18     
============================================
+ Hits          47436    47497      +61     
+ Misses        72408    72403       -5     
- Partials       5843     5850       +7     
Files Changed Coverage Δ
...n/java/de/uka/ilkd/key/rule/OneStepSimplifier.java 83.08% <90.62%> (-0.02%) ⬇️
...in/java/de/uka/ilkd/key/logic/PosInOccurrence.java 85.29% <100.00%> (+0.21%) ⬆️
...src/main/java/de/uka/ilkd/key/logic/PosInTerm.java 78.98% <100.00%> (+7.55%) ⬆️
...rc/main/java/de/uka/ilkd/key/proof/Statistics.java 64.48% <100.00%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FliegendeWurst FliegendeWurst marked this pull request as ready for review August 24, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant