Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem statements in KeY file can now also be a (semi-)sequent #3283

Merged
merged 4 commits into from Oct 4, 2023

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Sep 22, 2023

On request, this PR changes the grammar of KeY files, s.t. problem statements can also be sequents.

  • Previous: problem: LBRACE term RBRACE;
  • Now: problem: LBRACE termorseq RBRACE;

This means, you are allow to write

\problem {
   a,b,c 
    ==> 
     d, e, f
}

in KeY files.

@wadoon wadoon added KeY Parser Feature New feature or request labels Sep 22, 2023
@wadoon wadoon added this to the v2.14.0 milestone Sep 22, 2023
@wadoon wadoon self-assigned this Sep 22, 2023
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #3283 (605922f) into main (f6b120c) will decrease coverage by 0.01%.
The diff coverage is 64.70%.

@@             Coverage Diff              @@
##               main    #3283      +/-   ##
============================================
- Coverage     37.76%   37.75%   -0.01%     
- Complexity    16863    16864       +1     
============================================
  Files          2052     2052              
  Lines        125687   125697      +10     
  Branches      21234    21236       +2     
============================================
- Hits          47464    47462       -2     
- Misses        72389    72398       +9     
- Partials       5834     5837       +3     
Files Coverage Δ
...ore/src/main/java/de/uka/ilkd/key/proof/Proof.java 76.85% <100.00%> (-1.11%) ⬇️
...de/uka/ilkd/key/proof/init/KeYUserProblemFile.java 74.35% <60.00%> (ø)
...de/uka/ilkd/key/nparser/builder/ProblemFinder.java 64.00% <50.00%> (-9.69%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wadoon wadoon added the Review Request Waiting for review label Sep 29, 2023
@mattulbrich
Copy link
Member

That would be a nice feature. ... Wanted to have that for a while.

Copy link
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

I added a single commit where I renamed problemTerm to problem (and similar occurrences) for consistency.

@wadoon wadoon added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 3103e89 Oct 4, 2023
13 of 14 checks passed
@wadoon wadoon deleted the weigl/problemsequent branch October 4, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request KeY Parser Review Request Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants