Some general minor code quality improvements

[unp1]

The issues were:

• these unnecessary double declarations like
  for (T x: y) {
  var z = x;
  ....
  }
  fixed manually.
• reducing complexity of some very few if statements by switching the then-and-else branches (fixed automatically, but automatic fix triggered for each case manually)
• declared but never thrown exceptions (manual fixes)
• some typos in comments I encountered while fixing (manual fixes)

[codecov]

Codecov Report

Merging #3293 (783c430) into main (e5a80d4) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 41.37%.

❗ Current head 783c430 differs from pull request most recent head aac6798. Consider uploading reports for the commit aac6798 to get more accurate results

@@             Coverage Diff              @@
##               main    #3293      +/-   ##
============================================
- Coverage     37.78%   37.76%   -0.02%     
+ Complexity    16851    16846       -5     
============================================
  Files          2052     2052              
  Lines        125409   125394      -15     
  Branches      21220    21216       -4     
============================================
- Hits          47384    47354      -30     
- Misses        72189    72209      +20     
+ Partials       5836     5831       -5     

Files	Coverage Δ
...lkd/key/proof/InstantiationProposerCollection.java	100.00% <100.00%> (ø)
...in/java/de/uka/ilkd/key/proof/ProgVarReplacer.java	50.79% <ø> (ø)
...ey/proof/SVInstantiationExceptionWithPosition.java	26.66% <ø> (ø)
...ain/java/de/uka/ilkd/key/proof/TacletAppIndex.java	80.81% <ø> (ø)
...c/main/java/de/uka/ilkd/key/proof/TacletIndex.java	86.66% <100.00%> (-0.07%)	⬇️
.../uka/ilkd/key/proof/init/DependencyContractPO.java	0.00% <ø> (ø)
...ilkd/key/proof/init/FunctionalBlockContractPO.java	0.00% <ø> (ø)
.../ilkd/key/proof/init/FunctionalLoopContractPO.java	0.00% <ø> (ø)
.../key/proof/init/FunctionalOperationContractPO.java	54.40% <100.00%> (ø)
...de/uka/ilkd/key/proof/init/KeYUserProblemFile.java	74.35% <ø> (ø)
... and 37 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

[wadoon]

@unp1 Could you state if the changes are done semi-automatically, whether it was applied structurally, or how you selected certain classes? This would help for the review.

[unp1]

@unp1 Could you state if the changes are done semi-automatically, whether it was applied structurally, or how you selected certain classes? This would help for the review.

Hi,

thanks for the review! The issue detection was done automatically, but targeted by selecting specific analysis. The trigger for this issue was just that I stumbled about unnecessary local variable declarations on a different branch like

The issues were:

• these unnecessary double declarations like
  for (T x: y) {
  var z = x;
  ....
  }
  fixed manually.
• reducing complexity of some very few if statements by switching the then-and-else branches (fixed automatically, but automatic fix triggered for each case manually)
• declared but never thrown exceptions (manual fixes)
• some typos in comments I encountered while fixing (manual fixes)

Best regards,
Richard