Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable check for non-unique taclet names and remove two taclet duplicates #3359

Merged
merged 2 commits into from Nov 21, 2023

Conversation

unp1
Copy link
Member

@unp1 unp1 commented Nov 21, 2023

Intended Change

Taclet names must be unique (per rule option). The corresponding check was commented out.
This PR reenables the check and removes to duplicate taclets (identical taclets with equal names)

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I have tested the feature as follows: Load several problems to check whether an exception is thrown due to non-unique names

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@unp1 unp1 added 🐞 Bug Proof Loading/Saving Java Pull requests that update Java code labels Nov 21, 2023
@unp1 unp1 self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d5b0917) 37.94% compared to head (174ae11) 37.93%.

Files Patch % Lines
.../uka/ilkd/key/proof/mgt/RuleJustificationInfo.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3359      +/-   ##
============================================
- Coverage     37.94%   37.93%   -0.01%     
+ Complexity    17001    16997       -4     
============================================
  Files          2059     2059              
  Lines        125973   125972       -1     
  Branches      21273    21273              
============================================
- Hits          47798    47791       -7     
- Misses        72293    72298       +5     
- Partials       5882     5883       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon wadoon self-requested a review November 21, 2023 19:18
The file local declarations are already parsed by readEnvInput in ProblemInitializaer.
@wadoon wadoon added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 337dd55 Nov 21, 2023
13 of 14 checks passed
@wadoon wadoon deleted the removeDuplicateRules branch November 21, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull requests that update Java code 🐞 Bug Proof Loading/Saving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants