Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovation: package.html to package-info.java #3381

Merged
merged 2 commits into from Jan 12, 2024
Merged

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Dec 29, 2023

Intended Change

Renovation: Automatic translation of package.html to package-info.java.

  • Recommended since Java 1.5.
  • Allows setting annotation for complete package (e.g., @org.jspecify.NullMarked)

Type of pull request

  • X Refactoring (behaviour should not change or only minimally change)

It is recommended since Java 1.5 to use package-info.java. It also allows to set annotation for a whole package (in preparation for nullness checker).
@wadoon wadoon self-assigned this Dec 29, 2023
@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label Dec 29, 2023
@wadoon wadoon added this to the v2.14.0 milestone Dec 29, 2023
@wadoon wadoon changed the title weigl/package-info Renovation: package.html to package-info.java Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dc944b) 37.97% compared to head (1221667) 37.97%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3381   +/-   ##
=========================================
  Coverage     37.97%   37.97%           
  Complexity    17035    17035           
=========================================
  Files          2060     2060           
  Lines        126146   126146           
  Branches      21292    21292           
=========================================
  Hits          47910    47910           
  Misses        72351    72351           
  Partials       5885     5885           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon wadoon enabled auto-merge January 6, 2024 06:13
Copy link
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@wadoon wadoon added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit df9dc75 Jan 12, 2024
14 checks passed
@wadoon wadoon deleted the weigl/package-info branch January 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants