Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackeython smt mod #3418

Merged
merged 4 commits into from Feb 29, 2024
Merged

Conversation

BookWood7th
Copy link
Contributor

Intended Change

SMT-Translation translates mod as an uninterpreted symbol.
As div is translated as is, and SMT has an axiom stating a = a div b * b + a mod b. mod in SMT will be the same as in KeY.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: 5/2 -5/2 5/-2 -5/-2 and checking that mod is nonnegative and x mod y < |y|
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.77%. Comparing base (1fb0c10) to head (d15f5d3).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3418      +/-   ##
============================================
- Coverage     37.77%   37.77%   -0.01%     
  Complexity    17031    17031              
============================================
  Files          2076     2076              
  Lines        126950   126951       +1     
  Branches      21381    21381              
============================================
  Hits          47952    47952              
  Misses        73092    73092              
- Partials       5906     5907       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon wadoon added the SMT label Feb 23, 2024
@wadoon wadoon added this to the v2.14.0 milestone Feb 23, 2024
Copy link
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding modulo support to the SMT translation, and in particular also for adding the test!

@WolframPfeifer WolframPfeifer added this pull request to the merge queue Feb 29, 2024
@WolframPfeifer WolframPfeifer added the HacKeYthon Candidate Issue for HacKeYthon '24 label Feb 29, 2024
Merged via the queue into KeYProject:main with commit d637fd4 Feb 29, 2024
14 checks passed
@WolframPfeifer WolframPfeifer deleted the hackeython_smt_MOD branch February 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HacKeYthon Candidate Issue for HacKeYthon '24 SMT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants