Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the path-to-smt-solver bug in windows #3434

Merged
merged 4 commits into from Apr 23, 2024

Conversation

vb213
Copy link

@vb213 vb213 commented Feb 29, 2024

Intended Change

The specified path to a smt solver has been assembled incorrectly from the user input but still got cached in the proofIndependentSettings.props file. This caused a crash when restarting KeY.
Now,

  1. the path is assembled correctly and
  2. an invalid smt solver path in proofIndependentSettings.props will be ignored, thereby avoiding a crash on program start.

Type of pull request

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: ...
  • [X ] I have checked that runtime performance has not deteriorated.

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.91%. Comparing base (7254776) to head (f423328).
Report is 21 commits behind head on main.

❗ Current head f423328 differs from pull request most recent head b5f8c17. Consider uploading reports for the commit b5f8c17 to get more accurate results

Files Patch % Lines
.../key/smt/solvertypes/SolverTypeImplementation.java 59.09% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3434      +/-   ##
============================================
+ Coverage     37.86%   37.91%   +0.05%     
+ Complexity    17079    17071       -8     
============================================
  Files          2092     2076      -16     
  Lines        127596   127026     -570     
  Branches      21478    21385      -93     
============================================
- Hits          48316    48168     -148     
+ Misses        73355    72952     -403     
+ Partials       5925     5906      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please make sure your code follows the code formatting guidelines by running the spotlessApply gradle task. You can do so by executing ./gradlew key:spotlessApply in the repository root.

@wadoon wadoon self-requested a review April 20, 2024 09:58
@wadoon wadoon enabled auto-merge April 20, 2024 10:00
@wadoon wadoon added this to the v2.14.0 milestone Apr 20, 2024
Valentin Barner and others added 4 commits April 23, 2024 11:13
@wadoon wadoon added this pull request to the merge queue Apr 23, 2024
Merged via the queue into KeYProject:main with commit 8f62cf5 Apr 23, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants