New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the path-to-smt-solver bug in windows #3434
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3434 +/- ##
============================================
+ Coverage 37.86% 37.91% +0.05%
+ Complexity 17079 17071 -8
============================================
Files 2092 2076 -16
Lines 127596 127026 -570
Branches 21478 21385 -93
============================================
- Hits 48316 48168 -148
+ Misses 73355 72952 -403
+ Partials 5925 5906 -19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please make sure your code follows the code formatting guidelines by running the spotlessApply gradle task. You can do so by executing ./gradlew key:spotlessApply
in the repository root.
key.ui/src/main/java/de/uka/ilkd/key/gui/smt/settings/SMTSettingsProvider.java
Outdated
Show resolved
Hide resolved
key.ui/src/main/java/de/uka/ilkd/key/gui/smt/settings/SolverOptions.java
Outdated
Show resolved
Hide resolved
key.ui/src/main/java/de/uka/ilkd/key/gui/smt/settings/SolverOptions.java
Outdated
Show resolved
Hide resolved
key.core/src/main/java/de/uka/ilkd/key/smt/SolverTypeCollection.java
Outdated
Show resolved
Hide resolved
key.core/src/main/java/de/uka/ilkd/key/settings/ProofIndependentSMTSettings.java
Outdated
Show resolved
Hide resolved
ce2bd72
to
129afc9
Compare
Path variable is checked for the solvers name combined with the OS' default executable extension.
129afc9
to
b5f8c17
Compare
Intended Change
The specified path to a smt solver has been assembled incorrectly from the user input but still got cached in the proofIndependentSettings.props file. This caused a crash when restarting KeY.
Now,
Type of pull request
Ensuring quality
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.