Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup crash if ~/.key/colors.json is not present #3439

Merged
merged 1 commit into from Mar 8, 2024

Conversation

FliegendeWurst
Copy link
Member

Related Issue

This pull request fixes #3416.

Intended Change

This PR removes the fallback to the old .properties file in ColorSettings.
Due to an issue in static initialization order, it is not possible to use the SettingsManager to (attempt to) read the old configuration file.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@FliegendeWurst FliegendeWurst changed the title ColorSettings: drop old configuration file format Fix startup crash if ~/.key/colors.json is not present Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.85%. Comparing base (9ad6cc8) to head (4cf1755).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3439   +/-   ##
=========================================
  Coverage     37.85%   37.85%           
  Complexity    17042    17042           
=========================================
  Files          2082     2082           
  Lines        127290   127290           
  Branches      21441    21441           
=========================================
  Hits          48183    48183           
  Misses        73194    73194           
  Partials       5913     5913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon wadoon added this pull request to the merge queue Mar 8, 2024
Merged via the queue into KeYProject:main with commit 4382c2d Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeY crashes after initial launch terminates unconventionally
2 participants