New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends inside include #909

Closed

susonwaiba wants to merge 4 commits into Keats:master from susonwaiba:extends-inside-include

susonwaiba commented May 2, 2024 •

edited

Loading

For issues:

Changes:

Exposed current context
if template.parents is not empty
- Check and throw error, if include template has recursive parent template (to prevent loop)
- Using Processor
else
- render_body (as it was)
Removed error test
Removed Note from docs

Here, tera.get_template(tpl_name) seems to already parse parents if any exists.
Using Processor might create separate context ??
Performance ??

susonwaiba added 4 commits

May 2, 2024 22:20


          Feat: support for extends inside include

062959d


          Fix: removed failed errors_with_inheritance_in_included_template test

cd55e31


          Fix: removed Note from doc for extends inside include

28253ed


          Fix: added check if include template has recursive parent template

869c3b9

Owner

Keats commented May 3, 2024

I don't really want to add that feature though.

susonwaiba closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment