Disable unnecessary/unused regex features #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make the PR on the next branch? |
The case-insensitive flag `(?i)` requires regex with the unicode-case feature enabled which significantly increases the binary size and makes regex slower.
regex crate with default features enabled is huge, it significantly increases the binary size and compile time. Cargo features are additive, so once some feature is enabled anywhere in the dependency graph, there's no way to disable it, i.e. one (transitive) dependency infects the whole dependency graph. Since `#[validate(regex = "...")]` takes a path to a static Regex instance, not regex as a string, users have to add the `regex` dependency to their Cargo.toml to use it. Therefore, this change shouldn't break backward compatibility.
Ok, done. |
Keats
approved these changes
Jul 25, 2023
|
Thanks for merging! When can I expect a new release? |
|
Not anytime soon, the plan is to rewrite the derive macro for the next version |
|
If it takes longer, why don’t you just release the new version now and rewrite the macros in the next one? |
Keats
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Avoid unnecessary case-insensitive regexes The case-insensitive flag `(?i)` requires regex with the unicode-case feature enabled which significantly increases the binary size and makes regex slower. * Disable unnecessary/unused regex features regex crate with default features enabled is huge, it significantly increases the binary size and compile time. Cargo features are additive, so once some feature is enabled anywhere in the dependency graph, there's no way to disable it, i.e. one (transitive) dependency infects the whole dependency graph. Since `#[validate(regex = "...")]` takes a path to a static Regex instance, not regex as a string, users have to add the `regex` dependency to their Cargo.toml to use it. Therefore, this change shouldn't break backward compatibility.
Keats
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Avoid unnecessary case-insensitive regexes The case-insensitive flag `(?i)` requires regex with the unicode-case feature enabled which significantly increases the binary size and makes regex slower. * Disable unnecessary/unused regex features regex crate with default features enabled is huge, it significantly increases the binary size and compile time. Cargo features are additive, so once some feature is enabled anywhere in the dependency graph, there's no way to disable it, i.e. one (transitive) dependency infects the whole dependency graph. Since `#[validate(regex = "...")]` takes a path to a static Regex instance, not regex as a string, users have to add the `regex` dependency to their Cargo.toml to use it. Therefore, this change shouldn't break backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary case-insensitive regexes
The case-insensitive flag
(?i)requires regex with the unicode-casefeature enabled which significantly increases the binary size and makes
regex slower.
Disable unnecessary/unused regex features
regex crate with default features enabled is huge, it significantly
increases the binary size and compile time.
Cargo features are additive, so once some feature is enabled anywhere in
the dependency graph, there's no way to disable it, i.e. one
(transitive) dependency infects the whole dependency graph.
Since
#[validate(regex = "...")]takes a path to a static Regexinstance, not regex as a string, users have to add the
regexdependency to their Cargo.toml to use it. Therefore, this change
shouldn't break backward compatibility.