Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #323

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Update README #323

merged 1 commit into from
Apr 19, 2024

Conversation

nopeNoshishi
Copy link
Contributor

Hello! I am a user of this validator crate.

I recently had the opportunity to apply a custom validation. While reading the documentation, I noticed that the way to take arguments and add them to the validation differs from what is described in the README. It seems that the latest 0.18.0 has a different definition due to the implementation changes made by the following PR

Since this is the case, I decided to rewrite the README and create a PR.
While I made an effort to find related issues and PRs, I needed help locating them. If any are pending or planned, I would appreciate it if they could be addressed. I'm open to closing this if necessary.

I have confirmed that the code in the documentation works with 0.18.0, but I would appreciate it if you could point out any omissions.

Copy link
Owner

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Keats Keats merged commit 5dced8e into Keats:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants