Empty cells now return null

KeeTraxx · Sep 23, 2015 · 3a9cad0 · 3a9cad0
1 parent 0c47aef
commit 3a9cad0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/lib/Sheet.js b/lib/Sheet.js
@@ -150,7 +150,8 @@ function Sheet(basedir, file, contents, sharedStrings) {
             if (cell.$.t == 's') {
                 return sharedStrings[parseInt(cell.v)].t[0];
             } else if(cell.f && cell.v) {
-                return cell.v[0].hasOwnProperty('_') ? cell.v[0]._ : cell.v[0];
+                var value = cell.v[0].hasOwnProperty('_') ? cell.v[0]._ : cell.v[0];
+                return ( value != '' ) ? value : null;
             } else if (cell.f) {
                 // formula
                 return '=' + cell.f[0];

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kexcel",
-  "version": "2.0.13",
+  "version": "2.0.14",
   "description": "Create or open and then edit existing XLSX files",
   "keywords": [
     "xlsx",

diff --git a/test/functionvalues.js b/test/functionvalues.js
@@ -3,8 +3,7 @@ var fs = require('fs');
 var path = require('path');
 var should = chai.should();
 var kexcel = require('..');
-
-
+var expect = chai.expect;
 describe('Return values instead of functions', function () {
     var workbook;
     it('Open a input file...', function (done) {
@@ -22,4 +21,8 @@ describe('Return values instead of functions', function () {
         workbook.getSheet(0).getCellValue(2,1).should.equal('test with trailing white space ');
     });
 
+    it('Null test', function () {
+        expect( workbook.getSheet(0).getCellValue(3,1)).to.be.null;
+    });
+
 });
diff --git a/test/input-files/42.xlsx b/test/input-files/42.xlsx