Add correct tray menu provider #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed code from main plugin class. Added new class hierarchie for providing menu items.
This comment has been minimized.
This comment has been minimized.
Can not rename the namespace to KeeTrayTOTP.Extensions as there is a type which is named Extensions. This should be corrected in another PR.
robinvanpoppel
requested changes
Apr 26, 2020
And: - Removed unused usings. - Fixed some minor typos. - Added new unit test for invalid totp entries.
|
Kudos, SonarCloud Quality Gate passed!
|
robinvanpoppel
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #90
Work to do:
This is the new default way of accessing TOTP entries via tray
Multiple databases present
(The menu point for the database is displaying the database color)
Multiple databases, but some locked
They can be directly unlocked by clicking on them.
Legacy behavior
The legacy behavior can still be enabled (but requires an restart of keepass)
Thoughts and suggestions are welcome!