Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SonarQube in separate action #163

Merged
merged 2 commits into from May 17, 2020
Merged

Conversation

robinvanpoppel
Copy link
Collaborator

@robinvanpoppel robinvanpoppel commented May 17, 2020

Separate SonarQube actions in a separate workflow, so that it will also collect data on the master branch that is considered as the baseline. This will also make the (pre)release process less risky, because there is less work to do.

There is a bit of duplication between the PR build and the SonarQube action, but I think that's fine for now.

Separate SonarQube actions in a separate workflow,
so that it will also collect data on the master branch that is
considered as the baseline.

This will also make the (pre)release process less risky,
because there is less work to do.
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 34 Code Smells

52.8% 52.8% Coverage
0.0% 0.0% Duplication

@robinvanpoppel robinvanpoppel merged commit e056411 into master May 17, 2020
@robinvanpoppel robinvanpoppel deleted the separate-sonarqube branch May 17, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants