Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes deadlock situation if keepass is set to "always on top" #93

Merged
merged 1 commit into from Apr 9, 2020

Conversation

dannoe
Copy link
Contributor

@dannoe dannoe commented Apr 6, 2020

If you enable the keepass setting "always on top" (View -> Always on Top) and open the KeeTrayTOTP settings, the settings form is placed under the main keepass window. This creates a deadlock situation. (because it is a dialog and is not reachable)

Solution (this is only necessary if the form is opened as dialog):

  • Register forms at opening at the global windows manager of keepass
  • Unregister forms on closed

@dannoe dannoe force-pushed the fix-always-on-top-deadlock branch from 46b5f4c to 75ab859 Compare April 6, 2020 22:27
@dannoe
Copy link
Contributor Author

dannoe commented Apr 6, 2020

Wait for #92

@dannoe dannoe closed this Apr 6, 2020
@dannoe dannoe reopened this Apr 7, 2020
Copy link
Collaborator

@robinvanpoppel robinvanpoppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look tomorrow morning :)

Copy link
Collaborator

@robinvanpoppel robinvanpoppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dannoe dannoe merged commit 5836649 into master Apr 9, 2020
@dannoe dannoe deleted the fix-always-on-top-deadlock branch April 12, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants