Refactor code #96
Merged
Refactor code #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go through the code and cleanup as I go. The changes can be split up over multiple PR's, but I chose to do this in one go to see what I would end up with. These changes are not yet tested. * Removed dead code * Whitespace / newlines * Prefer var * Prefer not initializing fields explicitly * Seal classes * Use auto properties * Dispose of IDisposable instances
|
I did not find any issues testing this locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through the code and cleanup as I go.
The changes can be split up over multiple PR's, For now I chose to do this in one go and see what I would end up with. These changes are not yet tested.