Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc executable validation #30

Open
LeducNic opened this issue Feb 19, 2024 · 6 comments
Open

Javadoc executable validation #30

LeducNic opened this issue Feb 19, 2024 · 6 comments

Comments

@LeducNic
Copy link

On MacOS and Linux, the Javadoc executable don't ends with .exe

@KeeganBruer
Copy link
Owner

Ah, I knew I missed something. Good catch. I'll push a change in just a minute.

KeeganBruer added a commit that referenced this issue Feb 19, 2024
@KeeganBruer
Copy link
Owner

@LeducNic Changes pushed to marketplace. Should be available in a few minutes.

@LeducNic
Copy link
Author

Thank you for your excellent work. You are really fast. :)

About the executable, you still append the .exe when you add it to the config file even when we are on MacOS / Linux so the suggested executable is invalid. At least the detected path is correct, so I need to remove the .exe manually to make it work.

@KeeganBruer
Copy link
Owner

Oh, man. I keep missing these small things. Thanks for pointing them out. I'll add a way to detect system and append the correct extension for the executable.

@LeducNic
Copy link
Author

Maybe you could just check if the executable exist with .exe and if not just remove the .exe when you create the config file. You already make the check when the config file is saved. That way you could avoid more complex checks?

@KeeganBruer
Copy link
Owner

Love it. I'll get that added tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants