Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for custom command line switches #31

Closed
LeducNic opened this issue Feb 19, 2024 · 3 comments
Closed

Add field for custom command line switches #31

LeducNic opened this issue Feb 19, 2024 · 3 comments
Assignees

Comments

@LeducNic
Copy link

It would be useful to add a field in the json that let us write command line parameters that are not automatically generated by your script. For example, I want to specify to export only public or private class members. Also, I need to give the correct classpath to avoid export errors. So a field like:

"extra params" : "-public -cp junit.jar"

added to the json and inserted after the -o argument would be interesting. Maybe some tests would be needed to confirm the order of arguments

By the way, excellent work! Thank a lot for maintaining this extension.

@KeeganBruer
Copy link
Owner

Great Idea! I'll add it to the board. I was going to try and add every parameter as a config to the json. but that's a good way to support it in the meantime. I'll add that tonight.

@KeeganBruer KeeganBruer self-assigned this Feb 19, 2024
KeeganBruer added a commit that referenced this issue Feb 22, 2024
KeeganBruer added a commit that referenced this issue Feb 22, 2024
@KeeganBruer
Copy link
Owner

Feature added. I decided "raw_params" fit better with the future naming scheme. I'm going to close this issue for now, feel free to reopen if issues arise.

@LeducNic
Copy link
Author

Hello,

 A space is missing between rawParam and filteredFiles on line 172:

return ${javadoc_executable} ${sourcepath} ${distpath} ${rawParams}${filteredFiles.join(" ")};
and maybe two lines before also.

Right now I have to add a space at the end of my raw param list to "fix" that.

Have a great day
Nicolas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants