Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gradle files #317

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Improve Gradle files #317

merged 3 commits into from
Oct 2, 2018

Conversation

mickele
Copy link
Contributor

@mickele mickele commented Oct 1, 2018

This PR will change minor gradle things like:

  • Change double quotes to single quotes (this is already the code style for the project, except for those places where this change was applied)
  • Define the minSdkVersion at a single place (this was already done with the compileSdkVersion)
  • Upgrade gradle version to 4.10.2 (minor upgrade change to latest, also using "all" version instead of "bin" so AS stops complaining about documentation and other stuff)

There's should be no effect on the end library from this PR.

@mickele
Update gradle wrapper version
df93a5b 
Also use the "all" version instead of "bin" so Android Studio stops complaining about documentation.
@mickele
Use variables instead of fixed values for build system
c6deaa4 
This was already done for some configuration variables like `defCompileSdkVersion`.
@mickele
Use single quotes in gradle files
27093a5 
This is to make it concise with other gradle files.
@xiphirx xiphirx merged commit a5f4288 into KeepSafe:master Oct 2, 2018
@xiphirx
Copy link
Collaborator

xiphirx commented Oct 2, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mickele @xiphirx