-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with Android Library #100
Comments
Happy to take a look. Would you please re-run your build with a |
Thanks for looking into this.
|
Perfect, thanks! |
This was fixed as of version 0.5.2; please update your plugin and verify that it works. |
Thanks, |
Oh, thanks for letting me know - something seems to have gone wrong with the sync between Sonatype -> Maven Central. I'll check it out. |
Tracking the Sonatype issue here; https://issues.sonatype.org/browse/OSSRH-22593 |
Thank you |
So it seems that mvnrepository.com is lagging behind; the canonical source I don't see how it is possible that you would get the same error using the latest version. The method that was causing the crash is no longer referenced at all; if you are getting a crash using the new version, it has a different cause and I'll need a new stacktrace to see what happened. |
|
How do I know which version is being used? |
its complaining about this line: The method isAlive is only available in JDK >= 8 its not available in JDK 7 |
Thanks for the stacktrace; you're definitely using an old version. Wherever you added dexcount as a classpath dependency, that's where you'd see. Usually people put it in |
I tried the plugin using JDK 1.8 and now I'm getting a different error message:
|
I see. There is still an exception being thrown, but the method we use to print it, just throws another exception. How unfortunate! I wonder what the initial exception is; until this is fixed, I won't be able to tell. Thanks for reporting this; the logging, at least, will be a simple fix. |
@benjamin-bader I think this one Caused by: java.lang.UnsupportedOperationException
at org.gradle.logging.internal.AbstractStyledTextOutput$StyleOverrideTextOutput.exception(AbstractStyledTextOutput.java:167)
at org.gradle.logging.StyledTextOutput$exception$1.call(Unknown Source)
at com.getkeepsafe.dexcount.DexMethodCountTask$_countMethods_closure1.doCall(DexMethodCountTask.groovy:77)``` |
@iNoles this is thrown by Gradle's The actual problem that caused this is thereby masked by this one. I'll have a fix for the error-logging crash shortly. Just goes to show - ironically enough, it is error handling code that tends to be the buggiest. |
Hi, sorry for the delay. I've just released version 0.5.3, which contains a fix for the crash that happens while logging a crash 😭 If you try the new version (with |
OK, if there's no further issue I'll close this out. Please re-open if you are still having this same problem. |
@benjamin-bader It seem that the issue is still there in
Unfortunately, I am using it in a library project, so I would rather delay switching to Java 8. Knowing the limitations you have listed in the README, are there any other alternatives? |
Thank you for reminding me; I must confess that I'd lost track of this bug. 0.5.3 did not fix the I'll be honest - there are already three strikes against me fixing this. One, there really shouldn't be any reason to continue using Java 7, even for library projects (just set I'll look in to working around the absence of |
@benjamin-bader Thank you for taking the time to look into this! One little question, completely unrelated to the issue (which is why I am gonna post it here): what did you mean by the |
It's basically the Gradle Java Plugin way to set the Read about the Gradle details here: https://docs.gradle.org/current/userguide/java_plugin.html#N1545F The only risk (which you already have using Java 7 in the first place) is using Java types that don't exist in Android. |
it does not work when I place it after
apply plugin: 'com.android.library'
Error message:
No signature of method: java.lang.UNIXProcess.isAlive() is applicable for argument types: () values: [] Possible solutions: split(groovy.lang.Closure), isCase(java.lang.Object)
The text was updated successfully, but these errors were encountered: