Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging level when using "-lwsc=true" (KC-290) #528

Merged
merged 2 commits into from Oct 4, 2021

Conversation

kihneman
Copy link
Contributor

@kihneman kihneman commented Oct 4, 2021

This PR fixes the logging level when using the option -lwsc=true. For some reason when this option is true, logging.basicConfig does not set the logging level according to the level parameter that is passed. The workaround is to use a separate logging.getLogger().setLevel to set the correct logging level.

On further investigation, the reason logging.basicConfig doesn't work in some situations is because of the following in the documentation:

This function does nothing if the root logger already has handlers configured, unless the keyword argument force is set to True.

@kihneman kihneman changed the title Fix logging level when using "-lwsc=true" Fix logging level when using "-lwsc=true" (KC-290) Oct 4, 2021
@sk-keeper sk-keeper merged commit b2488c6 into master Oct 4, 2021
@sk-keeper sk-keeper deleted the kc-290-fix-logging-level branch October 4, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants