Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused PublicKey in KeyPair #47

Merged
merged 1 commit into from Jan 19, 2024
Merged

Remove unused PublicKey in KeyPair #47

merged 1 commit into from Jan 19, 2024

Conversation

EndlessTrax
Copy link
Collaborator

The public key in the KeyPair struct is never used.

When adding the public key to the signature armor, the public key is derived from the private key provided to the ssh.Signer. Therefore, this attribute and the error checking logic for its presence in the Keeper record are superfluous.

Closes #46

@EndlessTrax EndlessTrax added the go Pull requests that update Go code label Jan 19, 2024
@EndlessTrax EndlessTrax self-assigned this Jan 19, 2024
@EndlessTrax EndlessTrax merged commit 214da8a into main Jan 19, 2024
3 checks passed
@EndlessTrax EndlessTrax deleted the remove-pubkey branch January 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Public Key Optional in Keeper Record
2 participants