Move all platform specific operations to their own implementations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves responses out to their own classes. Makes them easier to modify.
The code now uses the client in the Slack adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have on big implementation with many switches. We can refactor this into an
Adapterthat will expose anuploaderthat does the uploading and aresponderthat will send response messages. The script will no longer have details for Slack, S3, HipChat, RocketChat, BearyChat or Telegram. This will make it way easier to add (and test) new implementations.This implements: stephenyeargin#165
I also made the tests faster. This helps with: stephenyeargin#164