Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all blueprints in books #23

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

spenczar
Copy link
Contributor

@spenczar spenczar commented Dec 2, 2022

This changes behavior for blueprint books. With this change, if a blueprint book is held in the cursor, all blueprints in the book are updated. This is done recursively, updating any books within the book, too.

This was requested in https://mods.factorio.com/mod/GhostOnWater/discussion/636127bf321a67b094934dfb, and I agree with the request. I have a large blueprint book of train blueprints, and I'd like to update all of them in one pass. I have another book of hundreds of belt balancers - and likewise I want that to be updated in one go. Writing this PR was honestly quicker than doing each update one-by-one!

I haven't updated the changelog or any documentation; let me know whether you'd like me to do that or you prefer to do it yourself.

@KeinNiemand
Copy link
Owner

KeinNiemand commented Dec 8, 2022

While I don't have anything against updating all BP in BP books I'm not sure if this is something everyone would always want. so maybe add a mod setting to turn recursively update BP books on or off (probably on by default). Not sure if that setting is nearly nectary tough.
I'd be happy if you updated the changelog and maybe the readme (which is basically the same thing as the mod page), as this adds a feature I'd be version 0.11.0 , I'll change the date in the changelog when I release it. I won't say to to having to to less work myself, If you don't want to do it I will probably do it myself eventually but that would talke longer as I'm currently not activly working on this mod.

README.md Outdated
@@ -1,21 +1,22 @@
About this mod
============

This is a mod for the game Factorio.

This comment was marked as resolved.

@spenczar
Copy link
Contributor Author

Sure @KeinNiemand. I have put this behavior behind a setting which defaults to true and updated the readme and changelog.

@KeinNiemand KeinNiemand merged commit baac5e6 into KeinNiemand:master Dec 14, 2022
@spenczar spenczar deleted the update_books branch December 19, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants