feat(cli): add support for --edit and pre-commit #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeisukeYamashita
requested changes
Sep 21, 2023
Co-authored-by: KeisukeYamashita <19yamashita15@gmail.com>
KeisukeYamashita
changed the title
KeisukeYamashita
approved these changes
Sep 22, 2023
KeisukeYamashita
merged commit cfa41fc
into
KeisukeYamashita:main
16 of 17 checks passed
No problem :) Once you create a new release (v.0.1.3), here's an example default_install_hook_types: [pre-commit, commit-msg, prepare-commit-msg]
repos:
- repo: https://github.com/KeisukeYamashita/commitlint-rs
rev: v0.1.3
hooks:
- id: commitlint
After that, a simple |
|
@cylewitruk Sorry for the late reply 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use this together with pre-commit but noticed that support for
--editwas missing, so I went ahead and added at least the default using./.git/COMMIT_EDITMSG.Also added a
.pre-commit-hooks.yamlso that the repo can be used together withpre-commit. Nothing fancy here...And, thanks for this! Much better than the node commitlint solution for rust projects :)