Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): panic on empty commit or empty type #212

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

suyulin
Copy link
Contributor

@suyulin suyulin commented Nov 4, 2023

Why

commit message is "", it's panic。
commit message invalid type ,it's panic. like this “xx”。

@KeisukeYamashita
Copy link
Owner

Thank you, I'll take a look tonight!

Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, PTAL 🙏

.gitignore Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/rule/type.rs Outdated Show resolved Hide resolved
src/git.rs Outdated Show resolved Hide resolved
src/rule/scope.rs Outdated Show resolved Hide resolved
src/rule/type.rs Outdated Show resolved Hide resolved
@KeisukeYamashita KeisukeYamashita changed the title fix invalid type 🐞 fix(cli): panic on empty commit or empty type Nov 5, 2023
Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR name to match or format, thank you for your contribution.
It will be shipped soon 🏃

@KeisukeYamashita KeisukeYamashita merged commit 9329948 into KeisukeYamashita:main Nov 5, 2023
16 of 17 checks passed
@suyulin suyulin deleted the feat/fix-🐞 branch November 11, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants