Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Better logging #78

Closed
KelvinTegelaar opened this issue Oct 19, 2021 · 3 comments
Closed

Feature request: Better logging #78

KelvinTegelaar opened this issue Oct 19, 2021 · 3 comments
Labels

Comments

@KelvinTegelaar
Copy link
Owner

Is your feature request related to a problem? Please describe.
The logging engine currently works by adding entries to a text file, using a mutex to prevent parallel write issues. This works OKish but could use some improvements.

I'd also like to have logs be in a better format. We currently use

DATE, USER, MESSAGE, SEVERITY

I am proposing changing this to:

DATE, USER, TENANT, MESSAGE, SEVERITY

Each API should post to the log without exception. Severity levels should be:

DEBUG
INFO
WARN
ERROR
CRITICAL

By default, the log should only return the INFO/WARN/ERROR levels, and have a selection option for the full log.

@KelvinTegelaar KelvinTegelaar added enhancement New feature or request First Priority labels Oct 19, 2021
@KelvinTegelaar
Copy link
Owner Author

  • Added more logging into components
  • Added debug type logging
  • Added log filtering in API

@KelvinTegelaar
Copy link
Owner Author

@redanthrax added logging to the graph function, with a critical level for any actual call failure.

@KelvinTegelaar KelvinTegelaar added this to In progress in Version 1.2.0 Oct 19, 2021
@KelvinTegelaar
Copy link
Owner Author

And with the latest additions to the logging engine we can close this out. Logging interface can still use improvements, and that is planned in a new issue for 1.3

Version 1.2.0 automation moved this from In progress to Done Oct 26, 2021
KelvinTegelaar pushed a commit that referenced this issue Sep 26, 2023
[pull] dev from KelvinTegelaar:dev
JohnDuprey pushed a commit that referenced this issue Feb 27, 2024
[pull] dev from KelvinTegelaar:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

1 participant