Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TenantDefaultTimezone #2349

Merged

Conversation

OfficialEsco
Copy link
Contributor

UI for KelvinTegelaar/CIPP-API#753

The Input/Output is similar to https://github.com/open-networks/go-msgraph/blob/dd4cea7265c7e244f97c2979127fafed63142e04/supportedTimeZones.go#L82-L240
However i did notice (UTC-08:00) Pacific Time (US & Canada) is not accepted since its (UTC-08:00) Pacific Time (US and Canada)

You CAN use UTC, but the output is (UTC) Coordinated Universal Time which would result in the script trying to update the timezone every 3 hours.

I made Copilot create a Select for the list, but then i realized its 150 objects, which i'm not sure if we should include in the standards.json
(Maybe we should have a TimeZone list which we can query since it most likely accepts the same input?)

@KelvinTegelaar
Copy link
Owner

We can use a seperate datalist, or add an object to languageList.json, and then add 'externalSource' as an object in standards.json. If you want, I can accept this PR and do that for you.

@OfficialEsco
Copy link
Contributor Author

Please do =)

@KelvinTegelaar KelvinTegelaar merged commit 03c979d into KelvinTegelaar:dev Apr 24, 2024
4 of 5 checks passed
@OfficialEsco OfficialEsco deleted the TenantDefaultTimezone branch April 24, 2024 11:25
@OfficialEsco OfficialEsco mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants