Add a committed comparison benchmark #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on my machine (M1 Pro), I get the following on python 3.11:
```
Running rbloom
2.52s
Running pybloomfiltermmap3
4.78s
Running pybloom3
46.76s
Running flor
76.94s (via bytes because cannot convert 'float' object to bytes)
Running bloomfilter2
165.54s (via bytes because unsupported operand type(s) for <<: 'int' and 'float')
```
I didn't update the benchmark results in the README.
Per [updated guidance from rust][1], we should probably include the Cargo.lock. [1]: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on my machine (M1 Pro), I get the following on python 3.11:
I didn't update the benchmark results in the README, or update that (at least for me) pybloomfiltermmap3 seems to be fine on python 3.11 now.
Also, per updated guidance from rust, we should probably include the Cargo.lock.