Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to Pass Data Instead of Alpaca #7

Open
KendelChopp opened this issue Sep 12, 2020 · 0 comments
Open

Allow Users to Pass Data Instead of Alpaca #7

KendelChopp opened this issue Sep 12, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@KendelChopp
Copy link
Owner

Allow users to pass in data instead of requesting it through passed in Alpaca. This would benefit us in 2 ways:

  1. Most importantly, users would not have to pass in their authenticated Alpaca object into the package. Instead, they can fetch the data themselves then pass it in, and we never touch Alpaca.

  2. Allow users to retrieve data from sources outside of Alpaca to use for testing.

For this, we won't worry so much about verifying the schema of the data, but it is something we can think about down the line. Additionally, we should update the README to show users how to do this.

To accomplish this will likely require modifying:

  • Backtest constructor to accept Alpaca OR bar data
  • Websocket constructor to accept the loaded data
  • Websocket loadData to use the already loaded data rather than hitting the Alpaca object
  • README to reflect these changes.
@KendelChopp KendelChopp added the good first issue Good for newcomers label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant